FM2-212 : Extend allergyIntoleranceResource to support update delete. #212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
============================================
+ Coverage 81.98% 81.99% +0.01%
- Complexity 1626 1652 +26
============================================
Files 163 163
Lines 4239 4303 +64
Branches 518 524 +6
============================================
+ Hits 3475 3528 +53
+ Misses 520 495 -25
- Partials 244 280 +36 Continue to review full report at Codecov.
|
...t/java/org/openmrs/module/fhir2/providers/r4/AllergyIntoleranceFhirResourceProviderTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@Akayeshmantha Discovered unwanted spacing in the Test Classes.
.../main/java/org/openmrs/module/fhir2/providers/r3/AllergyIntoleranceFhirResourceProvider.java
Outdated
Show resolved
Hide resolved
.../resources/org/openmrs/module/fhir2/providers/AllergyIntoleranceWebTest_UpdateWithoutId.json
Show resolved
Hide resolved
|
thanks @ibacher for the rebase |
|
@ibacher @corneliouzbett did the changes. |
Akayeshmantha
force-pushed
the
patch-3
branch
3 times, most recently
from
0e7dd38
to
723856a
Compare
|
@ibacher @corneliouzbett pushed the changes. I tried to rebase but it seems like there the merge branch commit was not rebased properly. I think it is possible to squash during the merge. If so that will be great thanks. |
.../main/java/org/openmrs/module/fhir2/providers/r3/AllergyIntoleranceFhirResourceProvider.java
Show resolved
Hide resolved
...java/org/openmrs/module/fhir2/providers/r3/AllergyIntoleranceFhirR3ResourceProviderTest.java
Show resolved
Hide resolved
Akayeshmantha
force-pushed
the
patch-3
branch
3 times, most recently
from
e554e9c
to
8d111eb
Compare
|
@ibacher pushed the changes I also added the tests for the task resource which was commented before. |
|
@corneliouzbett pushed all the changes. |
|
@corneliouzbett can we merge this |
...ava/org/openmrs/module/fhir2/providers/r4/AllergyIntoleranceFhirResourceProviderWebTest.java
Outdated
Show resolved
Hide resolved
...a/org/openmrs/module/fhir2/providers/r3/AllergyIntoleranceFhirR3ResourceProviderWebTest.java
Outdated
Show resolved
Hide resolved
Akayeshmantha
force-pushed
the
patch-3
branch
3 times, most recently
from
da5f6be
to
9b1d672
Compare
|
Hi @ibacher thanks for the fix. I fixed the build back. And squashed the commits |
|
Yeah, I need to stop using the GitHub edit feature to try to fix things. Thanks! |
Description of what I changed
Extend allergyIntoleranceResource to support update delete opertions.
Issue I worked on
see https://issues.openmrs.org/browse/FM2-212
Checklist: I completed these to help reviewers :)
[ X] My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend[ X] I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amend[ X] I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
[ X] All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
[ X] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master